[
https://issues.apache.org/jira/browse/YARN-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130651#comment-17130651
]
Adam Antal commented on YARN-10304:
-----------------------------------
Thanks for the updated patch [~gandras]! Looks much better.
Some additional items:
- I think
{{LogAggregationFileControllerFactory#getGroupedLogAggregationFileControllers}}
is unnecessary. You can use
{{LogAggregationFileControllerFactory#getConfiguredLogAggregationFileControllerList}},
but you have to add expose the name of the controller in
{{LogAggregationFileController}} preferably using a getter method for its name
(it's haven't been implemented).
- Please add the {{//JAXB needs this}} comment to the public constructors of
the DAO objects.
- In the {{testRemoteLogDir}} test case I think a different {{Configuration}}
class should be used. If the asserts fail, the configurations will not be
restored and the other tests may be affected. Creating a separate configuration
object however is better at separating the test suite's global configuration
from this one. Also you don't have to restore the original settings in that
case - so it's less error prone.
If these issues are fixed, we can push this forward.
> Create an endpoint for remote application log directory path query
> ------------------------------------------------------------------
>
> Key: YARN-10304
> URL: https://issues.apache.org/jira/browse/YARN-10304
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Minor
> Attachments: YARN-10304.001.patch, YARN-10304.002.patch,
> YARN-10304.003.patch
>
>
> The logic of the aggregated log directory path determination (currently based
> on configuration) is scattered around the codebase and duplicated multiple
> times. By providing a separate class for creating the path for a specific
> user, it allows for an abstraction over this logic. This could be used in
> place of the previously duplicated logic, moreover, we could provide an
> endpoint to query this path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
