Tao Yang commented on YARN-10319:

Thanks [~adam.antal] for the review and comments, [~prabhujoseph], could you 
please consider these suggestions as well?
Most changes in the latest patch LGTM, a minor suggestion is to change root 
element name of BulkActivitiesInfo from "schedulerActivities" to 
"bulkActivities", some related places like 
ActivitiesTestUtils#FN_SCHEDULER_BULK_ACT_ROOT should be changed as well.

> Record Last N Scheduler Activities from ActivitiesManager
> ---------------------------------------------------------
>                 Key: YARN-10319
>                 URL: https://issues.apache.org/jira/browse/YARN-10319
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>              Labels: activitiesmanager
>         Attachments: Screen Shot 2020-06-18 at 1.26.31 PM.png, 
> YARN-10319-001-WIP.patch, YARN-10319-002.patch, YARN-10319-003.patch, 
> YARN-10319-004.patch
> ActivitiesManager records a call flow for a given nodeId or a last call flow. 
> This is useful when debugging the issue live where the user queries with 
> right nodeId. But capturing last N scheduler activities during the issue 
> period can help to debug the issue offline.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to