[ 
https://issues.apache.org/jira/browse/YARN-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156965#comment-17156965
 ] 

Jim Brennan commented on YARN-10343:
------------------------------------

Thanks for the patch, [~epayne]. A few comments on the code:
 MetricsOverviewTable.render()
 * the names {{usedMemoryMB}}, {{totalMemoryMB}}, {{reservedMemoryMB}} imply 
that they are values in Megabytes, but they are actually in bytes. Maybe 
{{*MemoryBytes}} would be more appropriate.
 * The test failures in TestRMWebServices seem relevant.

{quote}ResourceUsage#getAllUsed() includes all used and reserved resources 
across all partitions. This required me to subtract reserved from used for the 
final value for allocated resources.
{quote}
Do you know why this is the case?
{quote}The number of running containers still does not include labeled 
containers. I couldn't find the right API to get that value.
{quote}
I don't know this either.  Seems like it must be rolling up this value 
somewhere?


> Legacy RM UI should include labeled metrics for allocated, total, and 
> reserved resources.
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-10343
>                 URL: https://issues.apache.org/jira/browse/YARN-10343
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.10.0, 3.2.1, 3.1.3
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Major
>         Attachments: Screen Shot 2020-07-07 at 1.00.22 PM.png, Screen Shot 
> 2020-07-07 at 1.03.26 PM.png, YARN-10343.000.patch
>
>
> The current legacy RM UI only includes resources metrics for the default 
> partition. If a cluster has labeled nodes, those are not included in the 
> resource metrics for allocated, total, and reserved resources.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to