[ 
https://issues.apache.org/jira/browse/YARN-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159527#comment-17159527
 ] 

Eric Payne commented on YARN-10343:
-----------------------------------

Thanks again [~Jim_Brennan] and [~jhung] for your reviews.

I have attached patch 001 for trunk.
- This patch renamed the MB variables to indicate they are bytes, not megabytes.
- I left the code as it is wrt subtracting reserved resources from used 
resources:
{code:title=MetricsOverviewTable#render}
+      usedMemoryBytes -= reservedMemoryBytes;
+      usedVCores -= reservedVCores;
{code}
-- I didn't want to make changes to the various allocateResource paths that 
call {{ResourceUsage#incUsed}}.
- I was able to use the root queue's {{ParentQueue#getNumContainers}} to get 
all labeled and non-labeled containers. However, it also includes reserved 
containers. In this case, it may be fine since there is not a separate 
"Reserved Containers" field.

> Legacy RM UI should include labeled metrics for allocated, total, and 
> reserved resources.
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-10343
>                 URL: https://issues.apache.org/jira/browse/YARN-10343
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.10.0, 3.2.1, 3.1.3
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Major
>         Attachments: Screen Shot 2020-07-07 at 1.00.22 PM.png, Screen Shot 
> 2020-07-07 at 1.03.26 PM.png, YARN-10343.000.patch, YARN-10343.001.patch
>
>
> The current legacy RM UI only includes resources metrics for the default 
> partition. If a cluster has labeled nodes, those are not included in the 
> resource metrics for allocated, total, and reserved resources.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to