[
https://issues.apache.org/jira/browse/YARN-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161040#comment-17161040
]
Szilard Nemeth commented on YARN-10278:
---------------------------------------
Hi [~epayne],
Thanks for taking care of reviewing the patches I've uploaded.
It seems like branch-2.10 would involve more work as it has some conflicts.
Also, 2.10 builds are not triggering, I saw this phenomenon while looking at
some other jiras.
Do you want to stick to the 2.10 patch?
> CapacityScheduler test framework
> ProportionalCapacityPreemptionPolicyMockFramework need some review
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-10278
> URL: https://issues.apache.org/jira/browse/YARN-10278
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Gergely Pollak
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-10278.001.patch, YARN-10278.002.patch,
> YARN-10278.branch-3.1.001.patch, YARN-10278.branch-3.1.002.patch,
> YARN-10278.branch-3.1.003.patch, YARN-10278.branch-3.2.001.patch,
> YARN-10278.branch-3.2.002.patch
>
>
> This test framework class mocks a bit too heavily, and simulates CS internal
> behaviour with the mock methods over a point it is reasonably maintainable,
> any internal change in CS is a major headscratch.
> A lot of tests depend on this class, so we should approach it carefully, but
> I think it's wroth to examine this class if it can be made a bit more
> resilient to changes, and easier to maintain. Or at least document it better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
