[ https://issues.apache.org/jira/browse/YARN-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165927#comment-17165927 ]
Eric Payne commented on YARN-10278: ----------------------------------- bq. The new patch is only uploaded to trigger the build and have a more fresh Jenkins result, nothing else. OK. Thanks for the clarification. You can kick the precommit build by going to https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/, logging in, and clicking "Build with Parameters" > CapacityScheduler test framework > ProportionalCapacityPreemptionPolicyMockFramework need some review > --------------------------------------------------------------------------------------------------- > > Key: YARN-10278 > URL: https://issues.apache.org/jira/browse/YARN-10278 > Project: Hadoop YARN > Issue Type: Task > Reporter: Gergely Pollak > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-10278.001.patch, YARN-10278.002.patch, > YARN-10278.002.patch, YARN-10278.branch-3.1.001.patch, > YARN-10278.branch-3.1.002.patch, YARN-10278.branch-3.1.003.patch, > YARN-10278.branch-3.2.001.patch, YARN-10278.branch-3.2.002.patch, > YARN-10278.branch-3.3.001.patch > > > This test framework class mocks a bit too heavily, and simulates CS internal > behaviour with the mock methods over a point it is reasonably maintainable, > any internal change in CS is a major headscratch. > A lot of tests depend on this class, so we should approach it carefully, but > I think it's wroth to examine this class if it can be made a bit more > resilient to changes, and easier to maintain. Or at least document it better. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org