[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192844#comment-17192844
]
Andras Gyori commented on YARN-10031:
-------------------------------------
Thanks [~adam.antal] for the review. I agree with the naming convention,
therefore I would stick to the extended nomenclature. As for the additional
comments:
* Unfortunately LogReader is not implementing AutoClosable, hence try-with is
not usable in this context
* Could you elaborate more on that simplification? I am having a hard-time
following it
* The parameter collections are interpreted as multiple expressions, with AND
logical expressions between them. To elaborate it with an example:
{noformat}
?file_size=>0&file_size=<1500 {noformat}
Is interpreted as:
{noformat}
filter metadata, whose size are greater, than 0 AND less, than 1500.{noformat}
As soon as we agree on a somewhat stabilized structure of this feature, I will
commit the unit tests as well.
> Create a general purpose log request with additional query parameters
> ---------------------------------------------------------------------
>
> Key: YARN-10031
> URL: https://issues.apache.org/jira/browse/YARN-10031
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Adam Antal
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10031-WIP.001.patch, YARN-10031.001.patch
>
>
> The current endpoints are robust but not very flexible with regards to
> filtering options. I suggest to add an endpoint which provides filtering
> options.
> E.g.:
> In ATS we have multiple endpoints:
> /containers/{containerid}/logs/{filename}
> /containerlogs/{containerid}/{filename}
> We could add @QueryParams parameters to the REST endpoints like this:
> /containers/{containerid}/logs?fileName=stderr&containerState=FAILED&nodeId=nm45
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
