[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197729#comment-17197729
]
Adam Antal commented on YARN-10031:
-----------------------------------
Thanks for the response [~gandras].
I accidentally made an error in my previous comment, sorry for that. By
simplification I meant this:
{code:java}
if (key.toString().equals(logRequest.getContainerId())) {
...
}
{code}
because this one statement covers the null check as well and is more concise.
Regarding the parameter collections I can understand the behaviour from the
unit tests. IMO since the approach is fine, we can go ahead with the next step.
> Create a general purpose log request with additional query parameters
> ---------------------------------------------------------------------
>
> Key: YARN-10031
> URL: https://issues.apache.org/jira/browse/YARN-10031
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Adam Antal
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10031-WIP.001.patch, YARN-10031.001.patch
>
>
> The current endpoints are robust but not very flexible with regards to
> filtering options. I suggest to add an endpoint which provides filtering
> options.
> E.g.:
> In ATS we have multiple endpoints:
> /containers/{containerid}/logs/{filename}
> /containerlogs/{containerid}/{filename}
> We could add @QueryParams parameters to the REST endpoints like this:
> /containers/{containerid}/logs?fileName=stderr&containerState=FAILED&nodeId=nm45
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
