[
https://issues.apache.org/jira/browse/YARN-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226857#comment-17226857
]
Eric Payne commented on YARN-10278:
-----------------------------------
{quote}
bq. It seems like branch-2.10 would involve more work as it has some conflicts.
Do you want to stick to the 2.10 patch?
How much work is it? I would really like this to be consistent back to 2.10.
{quote}
[~snemeth], I don't think we need to pull this back to 2.10. I am fine with
backporting only as far as 3.1
Since it has been several months, the patches have gone stale. We will need to
upmerge them to the HEAD of the branches.
> CapacityScheduler test framework
> ProportionalCapacityPreemptionPolicyMockFramework need some review
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-10278
> URL: https://issues.apache.org/jira/browse/YARN-10278
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Gergely Pollak
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-10278.001.patch, YARN-10278.002.patch,
> YARN-10278.002.patch, YARN-10278.branch-3.1.001.patch,
> YARN-10278.branch-3.1.002.patch, YARN-10278.branch-3.1.003.patch,
> YARN-10278.branch-3.2.001.patch, YARN-10278.branch-3.2.002.patch,
> YARN-10278.branch-3.3.001.patch
>
>
> This test framework class mocks a bit too heavily, and simulates CS internal
> behaviour with the mock methods over a point it is reasonably maintainable,
> any internal change in CS is a major headscratch.
> A lot of tests depend on this class, so we should approach it carefully, but
> I think it's wroth to examine this class if it can be made a bit more
> resilient to changes, and easier to maintain. Or at least document it better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
