[
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264018#comment-17264018
]
zhuqi commented on YARN-10506:
------------------------------
Thank you [~gandras] for the comment, about the ApplicationPlacementContext
part:
I agree with : The auto queue creation should not be used when mapping rules
are turned off, therefore placement context driven AQC would be a limitation.
But the original AQC with capacity, use the conf.isAutoCreateChildQueueEnabled
for check. If we should auto create for queue mapping, we don't use
ApplicationPlacementContext to check, we can't consistent with original logic,
and autoCreateLeafQueue will always go to else when
conf.isAutoCreateChildQueueEnabled is false. W'd better to add a flag also if
we don't want to use ApplicationPlacementContext check, or just let something
like isEligibleForAutoQueueCreation ahead to autoCreateLeafQueue, which meets
the consistent auto create check for (ApplicationPlacementContext auto
creation, or other based auto creation).
And i forget to change this in update patch:
The same follow up patch should also clean up addQueue() method of
ResourceScheduler. It is only used by CapacitySchedulerPlanFollow, we don't
need to add it to the abstract class.
> Update queue creation logic to use weight mode and allow the flexible
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-10506
> URL: https://issues.apache.org/jira/browse/YARN-10506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10506-006-10504-010.patch,
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch,
> YARN-10506.001.patch, YARN-10506.002.patch, YARN-10506.003.patch,
> YARN-10506.004.patch, YARN-10506.005.patch, YARN-10506.006-combined.patch,
> YARN-10506.006.patch, YARN-10506.007.patch, YARN-10506.009.patch
>
>
> The queue creation logic should be updated to use weight mode and support the
> flexible creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
