[
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264237#comment-17264237
]
Wangda Tan commented on YARN-10506:
-----------------------------------
Thanks [~zhuqi] and [~gandras] for quick updates!
*I will review the latest patch (in detail) during my day time*, and to the
question:
{quote} However, I think this method should not take into account which mode
the parent is in, this should be handled outside of this. I think it is safe to
assume, that for empty queues just return WEIGHT, because it is more
restrictive, than PERCENTAGE mode. Lets wait for the opinion of [~wangda] about
it as well
{quote}
I would agree with the statement. We can revisit how we can do better to
distinguish WEIGHT, PERCENTAGE, ABS configuration, which needs additional
cleanup and refactoring. So far, I think it is good for this patch.
> Update queue creation logic to use weight mode and allow the flexible
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-10506
> URL: https://issues.apache.org/jira/browse/YARN-10506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10506-006-10504-010.patch,
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch,
> YARN-10506.001.patch, YARN-10506.002.patch, YARN-10506.003.patch,
> YARN-10506.004.patch, YARN-10506.005.patch, YARN-10506.006-combined.patch,
> YARN-10506.006.patch, YARN-10506.007.patch, YARN-10506.009.patch,
> YARN-10506.011.patch
>
>
> The queue creation logic should be updated to use weight mode and support the
> flexible creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
