[
https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266068#comment-17266068
]
Andras Gyori commented on YARN-10535:
-------------------------------------
Thank you [~shuzirra] for the patch. I do not have any major comment at this
point and I understand that you will add more test cases in the following
patches. One minor feedback:
* MappingRuleValidationContextImpl#isParentQueue: I think this method is not
about being a ParentQueue, but being a dynamic parent candidate, and I found it
a bit ambiguous. Also, the javadoc of the method talks about child queues, but
the ManagedParentQueues and AQC-enabled ParentQueues are different in that they
can have dynamic child queues. This is only a nit, and only address it if you
have enough time at hand.
> Make queue placement in CapacityScheduler compliant with auto-queue-placement
> -----------------------------------------------------------------------------
>
> Key: YARN-10535
> URL: https://issues.apache.org/jira/browse/YARN-10535
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Wangda Tan
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10535.001.patch
>
>
> Once YARN-10506 is done, we need to call the API from the queue placement
> policy to create queues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
