[
https://issues.apache.org/jira/browse/YARN-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266139#comment-17266139
]
Gergely Pollak commented on YARN-10535:
---------------------------------------
[~pbacsko] [~gandras] Thank you for the review, I fixed the most issues
(checkstyle might find some more). Also when jenkins can run the full test
suite we might get some test failures which needs to be fixed.
*7. {{MappingRuleValidationContextImpl}}: {{staticPartParent}} is initially
{{null}}. Any change of it remaining {{null}} after the {{while}} loop? If so,
a null check is warranted.*
There is an explicit check for null state of staticPartParent, but null is
totally legit, if there is no parent of the static part. But that case is
handled.
*I can't really comment on the validation logic because there a lot of string
operations and hopefully the unit tests will do their job.*
Tests only cover the current cases, they won't provide enough coverage, for
validation I've already added a few test, but I still need a few for the
CSMappingPlacementRule class.
*Talking about unit tests: {{TestMappingRuleValidationContextImpl}} was
extended with some new cases, does that provide enough coverage? Have you run
it through a coverage tool?*
Tests are still being written
*EDIT: ok, the patch does not compile yet, so probably the answer is "no".*
It won't compile until YARN-10506 is merged.
> Make queue placement in CapacityScheduler compliant with auto-queue-placement
> -----------------------------------------------------------------------------
>
> Key: YARN-10535
> URL: https://issues.apache.org/jira/browse/YARN-10535
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Wangda Tan
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10535.001.patch, YARN-10535.002.patch
>
>
> Once YARN-10506 is done, we need to call the API from the queue placement
> policy to create queues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
