[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278616#comment-17278616
]
Andras Gyori commented on YARN-10532:
-------------------------------------
Thank you [~zhuqi]Â for taking the time and fixing the feedbacks! The overall
logic seems good to me, but I still have some addition regarding the testing:
* The new policy class should have its own tests, where you check the
markedForDeletion and sentForDeletion sets with some mocked RM. Here you would
not need to care about what RM does, when you send the event, just make sure
the policy logic itself is correct. (check TestCapacitySchedulerLazyPreemption
for example)
* In TestCapacitySchedulerNewQueueAutoCreation checking the markedForDeletion
set is a policy internal variable, which should be only checked in the policy
test. In this test case, only the editSchedule should be invoked from the
policy class, nothing else.
* A test is missing for the case, when a queue has application, but policy is
invoked. This is really important not to remove queues that have applications
running, so it should be tested thoroughly.
> Capacity Scheduler Auto Queue Creation: Allow auto delete queue when queue is
> not being used
> --------------------------------------------------------------------------------------------
>
> Key: YARN-10532
> URL: https://issues.apache.org/jira/browse/YARN-10532
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10532.001.patch, YARN-10532.002.patch,
> YARN-10532.003.patch, YARN-10532.004.patch, YARN-10532.005.patch,
> YARN-10532.006.patch, YARN-10532.007.patch, YARN-10532.008.patch,
> YARN-10532.009.patch, YARN-10532.010.patch, YARN-10532.011.patch,
> YARN-10532.012.patch, YARN-10532.013.patch, YARN-10532.014.patch
>
>
> It's better if we can delete auto-created queues when they are not in use for
> a period of time (like 5 mins). It will be helpful when we have a large
> number of auto-created queues (e.g. from 500 users), but only a small subset
> of queues are actively used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
