[
https://issues.apache.org/jira/browse/YARN-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333520#comment-17333520
]
Eric Badger commented on YARN-10707:
------------------------------------
Thanks for the update, [~zhuqi]! The content looks good, I just have a few nits
on naming conventions.
{noformat}
+ public float getNodePhysGpus() throws Exception{
{noformat}
I think a better name for this method would be {{getTotalNodeGpuUtilization}}
and {{getNodeGpuUtilization}} would be better off as
{{getAvgNodeGpuUtilization}}. Then {{totalGpuUtilization}} would also be
changed to {{avgGpuUtilization}} in {{getAvgNodeGpuUtilization}}. This way we
have a clear distinction on what the methods are returning. Relevant Javadocs
would also be nice for each of the methods.
> Support custom resources in ResourceUtilization, and update Node GPU
> Utilization to use.
> ----------------------------------------------------------------------------------------
>
> Key: YARN-10707
> URL: https://issues.apache.org/jira/browse/YARN-10707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10707.001.patch, YARN-10707.002.patch,
> YARN-10707.003.patch, YARN-10707.004.patch, YARN-10707.005.patch,
> YARN-10707.006.patch, YARN-10707.007.patch, YARN-10707.008.patch,
> YARN-10707.009.patch
>
>
> Support gpu in ResourceUtilization, and update Node GPU Utilization to use
> first.
> It will be very helpful for other use cases about GPU utilization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
