[ https://issues.apache.org/jira/browse/YARN-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334727#comment-17334727 ]
Andras Gyori commented on YARN-10759: ------------------------------------- Uploaded an initial revision of this refactor. Currently I have skipped refactoring ManagedParent and AutoCreatedLeafQueue related logic. I have also kept this improvement as simple as possible. It is not justified yet to complicate things by: * Encapsulate child queue modes for a ParentQueue * Create new mode WEIGHT mode, as it is more of a subtype of RELATIVE mode This might change, however, according to the needs of the tasks defined under this Jira eg. YARN-9936. > Encapsulate queue config modes > ------------------------------ > > Key: YARN-10759 > URL: https://issues.apache.org/jira/browse/YARN-10759 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler > Reporter: Andras Gyori > Assignee: Andras Gyori > Priority: Major > Attachments: YARN-10759.001.patch > > > Capacity Scheduler queues have three modes: > * relative/percentage > * weight > * absolute > Most of them have their own: > * validation logic > * config setting logic > * effective capacity calculation logic > These logics can be easily extracted and encapsulated in separate config mode > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org