[ 
https://issues.apache.org/jira/browse/YARN-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513012#comment-17513012
 ] 

Akira Ajisaka commented on YARN-10548:
--------------------------------------

Hi all the reviewers, please do not +1 when spotbugs says -1.

Hi [~snemeth] - please fix the spotbugs error in YARN-11102 as follow-up. 
Otherwise I'll revert it because it raised not only spotbugs error but also 
increased javac, whitespace, and javadoc warnings.

> Decouple AM runner logic from SLSRunner
> ---------------------------------------
>
>                 Key: YARN-10548
>                 URL: https://issues.apache.org/jira/browse/YARN-10548
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: YARN-10548.001.patch, YARN-10548.002.patch, 
> YARN-10548.003.patch
>
>
> SLSRunner has too many responsibilities.
>  One of them is to parse the job details from the SLS input formats and 
> launch the AMs and task containers.
>  The AM runner logic could be decoupled.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to