Ding Ding created YARN-11144:
--------------------------------
Summary: ContainerShellWebSocket gives inaccurate log message
saying "... closed!" before trying to close the session
Key: YARN-11144
URL: https://issues.apache.org/jira/browse/YARN-11144
Project: Hadoop YARN
Issue Type: Bug
Components: yarn
Reporter: Ding Ding
Hello,
While viewing the MAPREDUCE-4262, it seems that the logging statements might
give inaccurate messages.
I also found another same issue: the in the line *143* of the file
[ContainerShellWebSocket|https://github.com/apache/hadoop/blob/dbd255f4a96474b31af2bd45c952ac7151a265b9/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerShellWebSocket.java/#L143],
the log messages says "{_}... closed!"{_}. However, there are other closing
actions (source code) after the logging statement, which means that the close
is still not completed.
Would it be better if we change the verb "closed" to "closing" to indicate the
action is in progress? Or can we move the logging statement to the end of the
method?
Related issue: https://issues.apache.org/jira/projects/YARN/issues/YARN-11143
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
