[
https://issues.apache.org/jira/browse/YARN-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579089#comment-17579089
]
ASF GitHub Bot commented on YARN-9425:
--------------------------------------
ayushtkn commented on code in PR #4731:
URL: https://github.com/apache/hadoop/pull/4731#discussion_r944736410
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -120,6 +121,14 @@ protected void serviceInit(Configuration conf) throws
Exception {
heartbeatInterval =
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INTERVAL_SECS;
}
+
+ heartbeatInitialDelay = conf.getLong(
+ YarnConfiguration.FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY_SECS,
+
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY_SECS);
+ if (heartbeatInitialDelay <= 0) {
+ heartbeatInitialDelay =
+
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY_SECS;
+ }
Review Comment:
Add a warn log here, that the configured value for the Config is wrong it
should be greater than 0, so using the default of....
And somewhere below an info log that we are using an initial delay of
{configured} {unit}
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -3920,6 +3920,13 @@ public static boolean isAclEnabled(Configuration conf) {
public static final String DEFAULT_FEDERATION_REGISTRY_BASE_KEY =
"yarnfederation/";
+ public static final String
FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY_SECS =
+ FEDERATION_PREFIX + "state-store.heartbeat.initial-delay-secs";
+
+ // 30 secs
+ public static final int
+ DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY_SECS = 30;
+
Review Comment:
Make the config support rather than binding it just with Seconds
> Make initialDelay configurable for
> FederationStateStoreService#scheduledExecutorService
> ---------------------------------------------------------------------------------------
>
> Key: YARN-9425
> URL: https://issues.apache.org/jira/browse/YARN-9425
> Project: Hadoop YARN
> Issue Type: Bug
> Components: federation
> Affects Versions: 3.1.0
> Reporter: Shen Yinjie
> Assignee: groot
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-9425_1.patch, YARN-9425_2.patch, YARN-9425_3.patch,
> YARN-9425_4.patch
>
>
> When enable YARN federation, subclusters info in Router Web UI cannot be
> loaded immediately, and client cannot find any active subclusters after 5mins
> by default ,which is configured by
> "yarn.federation.state-store.heartbeat-interval-secs".
> IMA,we should seperate 'initialDely' and 'delay' for
> FederationStateStoreService#scheduledExecutorService.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
