[
https://issues.apache.org/jira/browse/YARN-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580325#comment-17580325
]
ASF GitHub Bot commented on YARN-9425:
--------------------------------------
ashutoshcipher commented on code in PR #4731:
URL: https://github.com/apache/hadoop/pull/4731#discussion_r946800518
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -116,10 +117,24 @@ protected void serviceInit(Configuration conf) throws
Exception {
heartbeatInterval = conf.getLong(
YarnConfiguration.FEDERATION_STATESTORE_HEARTBEAT_INTERVAL_SECS,
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INTERVAL_SECS);
+
if (heartbeatInterval <= 0) {
heartbeatInterval =
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INTERVAL_SECS;
}
+
+ heartbeatInitialDelay = conf.getTimeDuration(
+ YarnConfiguration.FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY,
+
YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_HEARTBEAT_INITIAL_DELAY,
+ TimeUnit.SECONDS);
+
+ if (heartbeatInitialDelay <= 0) {
+ LOG.warn("{} configured value is wrong, must be at <= 0; using default
value of {}",
Review Comment:
Thanks for pointing it out. Sorry I missed it. Fixed it in latest commit.
Thanks for review and approval :)
> Make initialDelay configurable for
> FederationStateStoreService#scheduledExecutorService
> ---------------------------------------------------------------------------------------
>
> Key: YARN-9425
> URL: https://issues.apache.org/jira/browse/YARN-9425
> Project: Hadoop YARN
> Issue Type: Bug
> Components: federation
> Affects Versions: 3.1.0
> Reporter: Shen Yinjie
> Assignee: groot
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-9425_1.patch, YARN-9425_2.patch, YARN-9425_3.patch,
> YARN-9425_4.patch
>
>
> When enable YARN federation, subclusters info in Router Web UI cannot be
> loaded immediately, and client cannot find any active subclusters after 5mins
> by default ,which is configured by
> "yarn.federation.state-store.heartbeat-interval-secs".
> IMA,we should seperate 'initialDely' and 'delay' for
> FederationStateStoreService#scheduledExecutorService.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
