[ 
https://issues.apache.org/jira/browse/YARN-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841541#comment-13841541
 ] 

Carlo Curino commented on YARN-1471:
------------------------------------

Wei, I posted a patch that implements the change we discussed with Alejandro. 
Most of it is rather trivial, with one ugly exception. The subclassing of 
CapacityScheduler is basically a 1:1 copy of your ResourceSchedulerWrapper 
(changed to be a subclass instead of a wrapper). I don't have in mind a good 
alternative and I need to move foward with this somewhat quickly, if you have a 
better idea feel free to evolve our patch (or have a separate JIRA to prettify 
this). 
More importantly I tested it with both CapacityScheduler and FairScheduler and 
seems to work as intended, but I have limited understanding of all the metrics 
you collect and the functionalities of the simulator, as I just started using 
it, if you have a chance it would be great for you to test this more carefully. 
 
Thanks!

> The SLS simulator is not running the preemption policy for CapacityScheduler
> ----------------------------------------------------------------------------
>
>                 Key: YARN-1471
>                 URL: https://issues.apache.org/jira/browse/YARN-1471
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>            Priority: Minor
>
> The simulator does not run the ProportionalCapacityPreemptionPolicy monitor.  
> This is because the policy needs to interact with a CapacityScheduler, and 
> the wrapping done by the simulator breaks this. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to