[
https://issues.apache.org/jira/browse/YARN-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599035#comment-17599035
]
ASF GitHub Bot commented on YARN-11273:
---------------------------------------
slfan1989 commented on PR #4817:
URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1234447386
@goiri Please help to review the code again, thank you very much!
I have refactored the code as follows:
1. Use field names instead of index to improve code readability
2. Refactor the test code(TestSQLFederationStateStore.java)
2.1 General test to ensure that the definition can be executed normally in
FederationStateStoreBaseTest.
2.2 Test all procedures, including writing and reading, and verify the
content of the data.
2.3 Unit test for exceptions of add, update, and delete data.
> [RESERVATION] Federation StateStore: Support storage/retrieval of
> Reservations With SQL
> ---------------------------------------------------------------------------------------
>
> Key: YARN-11273
> URL: https://issues.apache.org/jira/browse/YARN-11273
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
