[
https://issues.apache.org/jira/browse/YARN-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599180#comment-17599180
]
ASF GitHub Bot commented on YARN-11273:
---------------------------------------
slfan1989 commented on code in PR #4817:
URL: https://github.com/apache/hadoop/pull/4817#discussion_r961158570
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java:
##########
@@ -76,38 +107,479 @@ public void testSqlConnectionsCreatedCount() throws
YarnException {
FederationStateStoreClientMetrics.getNumConnections());
}
- @Test(expected = NotImplementedException.class)
public void testAddReservationHomeSubCluster() throws Exception {
Review Comment:
> Should we just remove this?
> It will call the parent methods by default right?
Your understanding is accurate, we can delete all this method. When the test
is executed, it will call the parent methods by default, but deleting it
directly will bring some difficulties to the review, because it will be
difficult to compare the code. I will later Submit a refactored pr. For code
refactoring, these redundant codes will be deleted directly at that time.
> [RESERVATION] Federation StateStore: Support storage/retrieval of
> Reservations With SQL
> ---------------------------------------------------------------------------------------
>
> Key: YARN-11273
> URL: https://issues.apache.org/jira/browse/YARN-11273
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
