[ 
https://issues.apache.org/jira/browse/YARN-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640393#comment-17640393
 ] 

ASF GitHub Bot commented on YARN-5607:
--------------------------------------

susheel-gupta commented on PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1330105691

   Hi @ashutoshcipher , for this PR the tests are passing locally but failing 
at jenkin. So I tried it to fix using this 
[PR](https://github.com/apache/hadoop/pull/4770#issuecomment-1221420424) 
created by you. I tried to upgrade the version of junit here in this 
[commit](https://github.com/apache/hadoop/commit/f2bfbba96d8614eb61256d63a6c2320b7487e4c0)
 but it failed with this [jenkin log 
](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5119/6/console).
   Could you please look into it.
   Thanks!




> Document TestContainerResourceUsage#waitForContainerCompletion
> --------------------------------------------------------------
>
>                 Key: YARN-5607
>                 URL: https://issues.apache.org/jira/browse/YARN-5607
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: resourcemanager, test
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: Susheel Gupta
>            Priority: Major
>              Labels: newbie, pull-request-available
>
> The logic in TestContainerResourceUsage#waitForContainerCompletion 
> (introduced in YARN-5024) is not immediately obvious. It could use some 
> documentation. Also, this seems like a useful helper method. Should this be 
> moved to one of the mock classes or to a util class? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to