[
https://issues.apache.org/jira/browse/YARN-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655777#comment-17655777
]
ASF GitHub Bot commented on YARN-5607:
--------------------------------------
szilard-nemeth commented on PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1374763585
Hi @susheel-gupta
Thanks for working on this.
1. This should be a fairly simple and concise PR.
Now we are having 66 changed files. I don't see a reason to move
waitForState from MockRM and MockAM.
Especially now that ResourceManagerTesterUtil and MockRM / MockAM has the
logic scattered.
Before the patch, every related logic were in the MockRM / MockAM classes.
The description of the jira ticket says that the waitForContainerCompletion
method of TestContainerResourceUsage should be moved to a utility class or to a
mock class.
In this case, MockRM would be a perfect place to move it as this class has
similar methods already so the PR would be far more simple.
So I don't think creating ResourceManagerTesterUtil has any added value.
2. In fact, the original method in
org.apache.hadoop.yarn.server.resourcemanager.MockRM#waitForState is also kept
without any remaining usages so it should be removed.
3. It's not a good practice to mix a library upgrade / update (in this case
JUnit) with other code changes.
I understand that the tests were failing (as per this comment:
https://github.com/apache/hadoop/pull/5119#issuecomment-1330105691).
The JUnit stuff has to go in before this patch, with a separate jira.
Please file another jira for the JUnit upgrade. You can mention that what
was the reason to use the new version of it.
> Document TestContainerResourceUsage#waitForContainerCompletion
> --------------------------------------------------------------
>
> Key: YARN-5607
> URL: https://issues.apache.org/jira/browse/YARN-5607
> Project: Hadoop YARN
> Issue Type: Test
> Components: resourcemanager, test
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Susheel Gupta
> Priority: Major
> Labels: newbie, pull-request-available
>
> The logic in TestContainerResourceUsage#waitForContainerCompletion
> (introduced in YARN-5024) is not immediately obvious. It could use some
> documentation. Also, this seems like a useful helper method. Should this be
> moved to one of the mock classes or to a util class?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
