[
https://issues.apache.org/jira/browse/YARN-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680963#comment-17680963
]
ASF GitHub Bot commented on YARN-11416:
---------------------------------------
p-szucs commented on code in PR #5320:
URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087762346
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -172,37 +170,41 @@ private void createConverter() {
public void testDefaultMaxAMShare() throws Exception {
converter.convert(config);
- Configuration conf = converter.getCapacitySchedulerConfig();
+ CapacitySchedulerConfiguration conf =
converter.getCapacitySchedulerConfig();
String maxAmShare =
conf.get(CapacitySchedulerConfiguration.
MAXIMUM_APPLICATION_MASTERS_RESOURCE_PERCENT);
Review Comment:
There is a getMaximumApplicationMasterResourcePercent() method in the
CapacitySchedulerConfiuration class which returns this value. Could you please
use that here?
> FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder
> ---------------------------------------------------------------------------
>
> Key: YARN-11416
> URL: https://issues.apache.org/jira/browse/YARN-11416
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Benjamin Teke
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSQueueConverter
> and its builder stores the variable capacitySchedulerConfig as a simple
> Configuration object instead of CapacitySchedulerConfiguration. This is
> misleading, as capacitySchedulerConfig suggests that it is indeed a
> CapacitySchedulerConfiguration and it loses access to the convenience methods
> to check for various properties. Because of this every time a property getter
> is changed FS2CS should be checked if it reimplemented the same, otherwise
> there might be behaviour differences or even bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
