[
https://issues.apache.org/jira/browse/YARN-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681020#comment-17681020
]
ASF GitHub Bot commented on YARN-11416:
---------------------------------------
brumi1024 commented on PR #5320:
URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1405165777
> > I added some comments where I saw further possibilities for using the
convenience get methods beside the fixed ones. I also saw that there are some
config settings in the FsQueueConverter class where the
CapacitySchedulerConfiguration’s setter methods could be used too, so that way
we would have only one place for setting these values.
> > For example here we can use the CapacitySchedulerConfiguration’s
setMaximumCapacity() method:
> >
https://github.com/apache/hadoop/blob/a38eb1f19318e3dd34d9312afe1096db46652f49/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java#L167
> >
> > What are your thoughts on that @brumi1024, @susheel-gupta?
>
> I think the setters can be handled in another separate jira. What do you
suggest @p-szucs @brumi1024 ?
I agree with @p-szucs, it strongly connects to this PR, so it be best to do
it in one go.
> FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder
> ---------------------------------------------------------------------------
>
> Key: YARN-11416
> URL: https://issues.apache.org/jira/browse/YARN-11416
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Benjamin Teke
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSQueueConverter
> and its builder stores the variable capacitySchedulerConfig as a simple
> Configuration object instead of CapacitySchedulerConfiguration. This is
> misleading, as capacitySchedulerConfig suggests that it is indeed a
> CapacitySchedulerConfiguration and it loses access to the convenience methods
> to check for various properties. Because of this every time a property getter
> is changed FS2CS should be checked if it reimplemented the same, otherwise
> there might be behaviour differences or even bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
