[ 
https://issues.apache.org/jira/browse/YARN-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698853#comment-17698853
 ] 

ASF GitHub Bot commented on YARN-11427:
---------------------------------------

susheelgupta7 commented on PR #5465:
URL: https://github.com/apache/hadoop/pull/5465#issuecomment-1463567272

   @bteke I have one query related to this comment of steve 
https://github.com/apache/hadoop/pull/5295#issuecomment-1419556104  for 
versioned imports pull up into the hadoop-project.
   Question: Is it good idea to match the version according to hadoop-project 
pom ?.
   Like here in this file it contain different dependency version on comparing 
hadoop-project pom.
   
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/pom.xml#L62
 
   https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L1307 




> Pull up the versioned imports in pom of hadoop-mapreduce-client-app to 
> hadoop-project pom
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-11427
>                 URL: https://issues.apache.org/jira/browse/YARN-11427
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: yarn
>            Reporter: Susheel Gupta
>            Assignee: Susheel Gupta
>            Priority: Minor
>              Labels: pull-request-available
>
> The versioned imports in pom.xml of hadoop-mapreduce-client-app can be pulled 
> up to hadoop-project pom as it is better for version maintenance and  ease of 
> using an IDE to find where things are used
>  
> {code:java}
>     <dependency>
>       <groupId>org.mockito</groupId>
>       <artifactId>mockito-junit-jupiter</artifactId>
>       <version>4.11.0</version>
>       <scope>test</scope>
>     </dependency>
>     <dependency>
>       <groupId>uk.org.webcompere</groupId>
>       <artifactId>system-stubs-core</artifactId>
>       <version>1.1.0</version>
>       <scope>test</scope>
>     </dependency>
>     <dependency>
>       <groupId>uk.org.webcompere</groupId>
>       <artifactId>system-stubs-jupiter</artifactId>
>       <version>1.1.0</version>
>       <scope>test</scope>
>     </dependency> {code}
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to