[
https://issues.apache.org/jira/browse/YARN-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719022#comment-17719022
]
ASF GitHub Bot commented on YARN-11427:
---------------------------------------
steveloughran commented on PR #5465:
URL: https://github.com/apache/hadoop/pull/5465#issuecomment-1533516959
the pom move should be separate from the source changes.
I really do not see the point in moving from the original junit calls to the
jupiter ones. Seriously: why are we making our lives harder for ourselves
unless/until they actually cut the old ones? At which point: why stay with the
sessions from a project which is prepared to break existing code.
I know there are some extra features, specifically java8 support and the
ability to generate errors dynamically, but AssertJ is really good here and it
can coexist with JUnit 4 quite happily.
As you have already done the change, I am =0 on that move. However, be aware
that if you ever ask me to review any tests in new code, my response will be
"use AssertJ". Is if you don't know it yet -your future PR will be that
opportunity. It is a lot better, despite its verbosity.
> Pull up the versioned imports in pom of hadoop-mapreduce-client-app to
> hadoop-project pom
> -----------------------------------------------------------------------------------------
>
> Key: YARN-11427
> URL: https://issues.apache.org/jira/browse/YARN-11427
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Minor
> Labels: pull-request-available
>
> The versioned imports in pom.xml of hadoop-mapreduce-client-app can be pulled
> up to hadoop-project pom as it is better for version maintenance and ease of
> using an IDE to find where things are used
>
> {code:java}
> <dependency>
> <groupId>org.mockito</groupId>
> <artifactId>mockito-junit-jupiter</artifactId>
> <version>4.11.0</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>uk.org.webcompere</groupId>
> <artifactId>system-stubs-core</artifactId>
> <version>1.1.0</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>uk.org.webcompere</groupId>
> <artifactId>system-stubs-jupiter</artifactId>
> <version>1.1.0</version>
> <scope>test</scope>
> </dependency> {code}
> This jira also contain YARN-11404 (the commit of this jira was reverted
> becasue of some testcase failure caused due to transitive dependency
> [issue|https://github.com/apache/hadoop/pull/5295#issuecomment-1439366770]).
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
