[
https://issues.apache.org/jira/browse/YARN-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847927#comment-13847927
]
Karthik Kambatla commented on YARN-1485:
----------------------------------------
The method {{HAUtil#verifyAndSetRMHAIdsList}} verifies there are at least two
RM-ids and RPC addresses are specified for each RM-id. Then, sets the rm-ids.
However, the method name doesn't capture all this. It would be nice to either
pick a name that captures this or add a comment at the beginning of the method
that explains all this.
Otherwise, the patch looks good to me. Depending on which goes first, this
might have to rebase on YARN-1028.
> Enabling HA should verify the RM service addresses configurations have been
> set for every RM Ids defined in RM_HA_IDs
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1485
> URL: https://issues.apache.org/jira/browse/YARN-1485
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1485.1.patch, YARN-1485.2.patch
>
>
> After YARN-1325, the YarnConfiguration.RM_HA_IDS will contain multiple
> RM_Ids. We need to verify that the RM service addresses configurations have
> been set for all of RM_Ids.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
