[
https://issues.apache.org/jira/browse/YARN-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724979#comment-17724979
]
ASF GitHub Bot commented on YARN-11497:
---------------------------------------
slfan1989 commented on code in PR #5681:
URL: https://github.com/apache/hadoop/pull/5681#discussion_r1200608735
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -1209,6 +1209,19 @@ public static boolean isAclEnabled(Configuration conf) {
public static final boolean
DEFAULT_RM_ENABLE_NODE_UNTRACKED_WITHOUT_INCLUDE_PATH = false;
+ /**
+ * When non empty, untracked nodes are deleted only if their state is one of
+ * the states defined by this config. When empty, all the states are eligible
+ * for removal
+ * Eligible states are defined by enum values here:
+ * @see org.apache.hadoop.yarn.api.records.NodeState
+ * Example: LOST,DECOMMISSIONED
+ */
+ public static final String
RM_NODEMANAGER_UNTRACKED_NODE_SELECTIVE_STATES_TO_REMOVE =
+ RM_PREFIX + "node-removal-untracked.node-selective-states-to-remove";
Review Comment:
Indentation, should be 5 characters.
> Support removal of only selective node states in untracked removal flow
> -----------------------------------------------------------------------
>
> Key: YARN-11497
> URL: https://issues.apache.org/jira/browse/YARN-11497
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Mudit Sharma
> Priority: Major
> Labels: pull-request-available
>
> Currently inactive nodes are removed from the Yarn local memory irrespective
> of which state they are in. This makes the node removal process not too much
> configurable
> After this patch: https://issues.apache.org/jira/browse/YARN-10854
> If autoscaling is enabled, lot many nodes go into DECOMMISSIONED state but
> still other states like LOST, SHUTDOWN are very less and systems might want
> them to be still visible on UI for better tracking
> The proposal is to introduce a new config, which when set, will allow only
> selective node states to be removed after going into untracked state.
>
> PR: [https://github.com/apache/hadoop/pull/5681]
> Any thoughts/suggestions/feedbacks are welcome!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
