[
https://issues.apache.org/jira/browse/YARN-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724980#comment-17724980
]
ASF GitHub Bot commented on YARN-11497:
---------------------------------------
slfan1989 commented on code in PR #5681:
URL: https://github.com/apache/hadoop/pull/5681#discussion_r1200610275
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java:
##########
@@ -146,6 +154,12 @@ public void run() {
NodeId nodeId = entry.getKey();
RMNode rmNode = entry.getValue();
if (isUntrackedNode(rmNode.getHostName())) {
+ if(CollectionUtils.isNotEmpty(untrackedSelectiveStatesToRemove) &&
+
!untrackedSelectiveStatesToRemove.contains(rmNode.getState().toString())) {
+ LOG.warn("Untracked node " + rmNode.getHostName() + " is not
part of " +
Review Comment:
log please use placeholder {}
> Support removal of only selective node states in untracked removal flow
> -----------------------------------------------------------------------
>
> Key: YARN-11497
> URL: https://issues.apache.org/jira/browse/YARN-11497
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Mudit Sharma
> Priority: Major
> Labels: pull-request-available
>
> Currently inactive nodes are removed from the Yarn local memory irrespective
> of which state they are in. This makes the node removal process not too much
> configurable
> After this patch: https://issues.apache.org/jira/browse/YARN-10854
> If autoscaling is enabled, lot many nodes go into DECOMMISSIONED state but
> still other states like LOST, SHUTDOWN are very less and systems might want
> them to be still visible on UI for better tracking
> The proposal is to introduce a new config, which when set, will allow only
> selective node states to be removed after going into untracked state.
>
> PR: [https://github.com/apache/hadoop/pull/5681]
> Any thoughts/suggestions/feedbacks are welcome!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
