[ 
https://issues.apache.org/jira/browse/YARN-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740703#comment-17740703
 ] 

ASF GitHub Bot commented on YARN-11464:
---------------------------------------

susheel-gupta commented on PR #5792:
URL: https://github.com/apache/hadoop/pull/5792#issuecomment-1623998900

   > 
   
   Thanks @brumi1024 , paramters for this method checkReservationSystem was 
yarnSite.xml, so was confused at that moment.




> <reservation> queue element is added to any other  leaf queue, it's queueType 
> becomes QueueType.PARENT_QUEUE
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-11464
>                 URL: https://issues.apache.org/jira/browse/YARN-11464
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.3.4
>            Reporter: Susheel Gupta
>            Assignee: Susheel Gupta
>            Priority: Major
>              Labels: pull-request-available
>
> This testcase clearly reproduces the issue. There is a missing dot before 
> "auto-queue-creation-v2.enabled" for method call assertNoValueForQueues.
> {code:java}
> @Test
> public void testAutoCreateV2FlagsInWeightMode() {
>   converter = builder.withPercentages(false).build();
>   converter.convertQueueHierarchy(rootQueue);
>   assertTrue("root autocreate v2 flag",
>       csConfig.getBoolean(
>           PREFIX + "root.auto-queue-creation-v2.enabled", false));
>   assertTrue("root.admins autocreate v2 flag",
>       csConfig.getBoolean(
>           PREFIX + "root.admins.auto-queue-creation-v2.enabled", false));
>   assertTrue("root.users autocreate v2 flag",
>       csConfig.getBoolean(
>           PREFIX + "root.users.auto-queue-creation-v2.enabled", false));
>   assertTrue("root.misc autocreate v2 flag",
>       csConfig.getBoolean(
>           PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
>   Set<String> leafs = Sets.difference(ALL_QUEUES,
>       Sets.newHashSet("root",
>           "root.default",
>           "root.admins",
>           "root.users",
>           "root.misc"));
>   assertNoValueForQueues(leafs, "auto-queue-creation-v2.enabled",
>       csConfig);
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to