[
https://issues.apache.org/jira/browse/YARN-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741672#comment-17741672
]
ASF GitHub Bot commented on YARN-11464:
---------------------------------------
brumi1024 commented on code in PR #5792:
URL: https://github.com/apache/hadoop/pull/5792#discussion_r1258475720
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java:
##########
@@ -351,13 +351,16 @@ public void testAutoCreateV2FlagsInWeightMode() {
csConfig.getBoolean(
PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
+ //leaf queue root.admins.alice is removed from the below list
+ //adding reservation to a leaf, it's queueType changes to FSParentQueue
Set<String> leafs = Sets.difference(ALL_QUEUES,
Sets.newHashSet("root",
"root.default",
"root.admins",
"root.users",
- "root.misc"));
- assertNoValueForQueues(leafs, "auto-queue-creation-v2.enabled",
+ "root.misc",
+ "root.admins.alice"));
Review Comment:
Nit: please add root.admins.alice to the assertTrue part as well, as
essentially it's expected to have the flag.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java:
##########
@@ -351,13 +351,16 @@ public void testAutoCreateV2FlagsInWeightMode() {
csConfig.getBoolean(
PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
+ //leaf queue root.admins.alice is removed from the below list
+ //adding reservation to a leaf, it's queueType changes to FSParentQueue
Set<String> leafs = Sets.difference(ALL_QUEUES,
Sets.newHashSet("root",
"root.default",
Review Comment:
"root.default" is misleading here, it should not have the
auto-queue-creation-v2.enabled flag, however because of the Sets.difference
call it's removed from this validation.
> <reservation> queue element is added to any other leaf queue, it's queueType
> becomes QueueType.PARENT_QUEUE
> ------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11464
> URL: https://issues.apache.org/jira/browse/YARN-11464
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Affects Versions: 3.3.4
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
>
> This testcase clearly reproduces the issue. There is a missing dot before
> "auto-queue-creation-v2.enabled" for method call assertNoValueForQueues.
> {code:java}
> @Test
> public void testAutoCreateV2FlagsInWeightMode() {
> converter = builder.withPercentages(false).build();
> converter.convertQueueHierarchy(rootQueue);
> assertTrue("root autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.auto-queue-creation-v2.enabled", false));
> assertTrue("root.admins autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.admins.auto-queue-creation-v2.enabled", false));
> assertTrue("root.users autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.users.auto-queue-creation-v2.enabled", false));
> assertTrue("root.misc autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
> Set<String> leafs = Sets.difference(ALL_QUEUES,
> Sets.newHashSet("root",
> "root.default",
> "root.admins",
> "root.users",
> "root.misc"));
> assertNoValueForQueues(leafs, "auto-queue-creation-v2.enabled",
> csConfig);
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
