[
https://issues.apache.org/jira/browse/YARN-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753645#comment-17753645
]
ASF GitHub Bot commented on YARN-11154:
---------------------------------------
slfan1989 commented on code in PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292595901
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:
##########
@@ -318,7 +329,23 @@ public GetClusterNodeLabelsResponse getClusterNodeLabels(
public GetApplicationReportResponse getApplicationReport(
GetApplicationReportRequest request) throws YarnException, IOException {
RequestInterceptorChainWrapper pipeline = getInterceptorChain();
- return pipeline.getRootInterceptor().getApplicationReport(request);
+ GetApplicationReportResponse response = pipeline.getRootInterceptor()
+ .getApplicationReport(request);
+ if (getConfig().getBoolean(YarnConfiguration.ROUTER_WEBAPP_PROXY_ENABLE,
Review Comment:
extend
```
Configuration conf = getConfig();
boolean isWebProxyEnabled =
conf.getBoolean(YarnConfiguration.ROUTER_WEBAPP_PROXY_ENABLE,
YarnConfiguration.DEFAULT_ROUTER_WEBAPP_PROXY_ENABLE);
```
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:
##########
@@ -318,7 +329,23 @@ public GetClusterNodeLabelsResponse getClusterNodeLabels(
public GetApplicationReportResponse getApplicationReport(
GetApplicationReportRequest request) throws YarnException, IOException {
RequestInterceptorChainWrapper pipeline = getInterceptorChain();
- return pipeline.getRootInterceptor().getApplicationReport(request);
+ GetApplicationReportResponse response = pipeline.getRootInterceptor()
+ .getApplicationReport(request);
+ if (getConfig().getBoolean(YarnConfiguration.ROUTER_WEBAPP_PROXY_ENABLE,
Review Comment:
extend
```
Configuration conf = getConfig();
boolean isWebProxyEnabled =
conf.getBoolean(YarnConfiguration.ROUTER_WEBAPP_PROXY_ENABLE,
YarnConfiguration.DEFAULT_ROUTER_WEBAPP_PROXY_ENABLE);
```
> Make router support proxy server.
> ---------------------------------
>
> Key: YARN-11154
> URL: https://issues.apache.org/jira/browse/YARN-11154
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.2.1
> Reporter: zhengchenyu
> Assignee: zhengchenyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-11154.draft.patch
>
>
> Detail message see: https://issues.apache.org/jira/browse/YARN-10775 and
> YARN-10775-design-doc.001.pdf
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
