[
https://issues.apache.org/jira/browse/YARN-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758796#comment-17758796
]
ASF GitHub Bot commented on YARN-8980:
--------------------------------------
zhengchenyu commented on PR #5975:
URL: https://github.com/apache/hadoop/pull/5975#issuecomment-1692675962
> ```
> List<Container> transferredContainers =
getScheduler().getTransferredContainers(applicationAttemptId);
> if (!transferredContainers.isEmpty()) {
> response.setContainersFromPreviousAttempts(transferredContainers);
>
rmContext.getNMTokenSecretManager().clearNodeSetForAttempt(applicationAttemptId);
> }
> ```
>
> **In this code, the main operations are retrieving transferred containers,
updating the response, and clearing the node set. All of these operations are
O(1), and they are not nested or iterated over a collection. Therefore, the
overall time complexity of this code is O(1).**
@whoami-anoint
Do you mean the complexity of this code is not O(1) after this PR?
I think the complexity of this code still is O(1) after this PR.
> Mapreduce application container start fail after AM restart.
> -------------------------------------------------------------
>
> Key: YARN-8980
> URL: https://issues.apache.org/jira/browse/YARN-8980
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin Chundatt
> Assignee: zhengchenyu
> Priority: Major
> Labels: pull-request-available
>
> UAM to subclusters are always launched with keepContainers.
> On AM restart scenarios , UAM register again with RM . UAM receive running
> containers with NMToken. NMToken received by UAM in
> getPreviousAttemptContainersNMToken is never used by mapreduce application.
> Federation Interceptor should take care of such scenarios too. Merge NMToken
> received at registration to allocate response.
> Container allocation response on same node will have NMToken empty.
> issue credits : [~Nallasivan]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
