[
https://issues.apache.org/jira/browse/YARN-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760902#comment-17760902
]
ASF GitHub Bot commented on YARN-8980:
--------------------------------------
slfan1989 commented on code in PR #5975:
URL: https://github.com/apache/hadoop/pull/5975#discussion_r1311543472
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
##########
@@ -1434,6 +1449,17 @@ private void mergeAllocateResponses(AllocateResponse
mergedResponse) {
}
}
}
+ // When re-register RM, client may not cache the NMToken from register
response.
+ // Here we pass these NMToken in allocate stage.
+ if (nmTokenMapFromRegisterSecondaryCluster.size() > 0) {
+ List<NMToken> duplicateNmToken = new
ArrayList(nmTokenMapFromRegisterSecondaryCluster);
Review Comment:
Why do we need to remove the token data from
`nmTokenMapFromRegisterSecondaryCluster`?
> Mapreduce application container start fail after AM restart.
> -------------------------------------------------------------
>
> Key: YARN-8980
> URL: https://issues.apache.org/jira/browse/YARN-8980
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin Chundatt
> Assignee: zhengchenyu
> Priority: Major
> Labels: pull-request-available
>
> UAM to subclusters are always launched with keepContainers.
> On AM restart scenarios , UAM register again with RM . UAM receive running
> containers with NMToken. NMToken received by UAM in
> getPreviousAttemptContainersNMToken is never used by mapreduce application.
> Federation Interceptor should take care of such scenarios too. Merge NMToken
> received at registration to allocate response.
> Container allocation response on same node will have NMToken empty.
> issue credits : [~Nallasivan]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
