[
https://issues.apache.org/jira/browse/YARN-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767339#comment-17767339
]
ASF GitHub Bot commented on YARN-8862:
--------------------------------------
goiri commented on code in PR #6083:
URL: https://github.com/apache/hadoop/pull/6083#discussion_r1332300958
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/test/java/org/apache/hadoop/yarn/server/globalpolicygenerator/applicationcleaner/TestDefaultApplicationCleaner.java:
##########
@@ -96,6 +119,13 @@ public void breakDown() {
stateStore.close();
stateStore = null;
}
+ if (registryClient != null) {
+ registryClient.cleanAllApplications();
Review Comment:
Can we null the registryClient too?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/subcluster/fair/TestYarnFederationWithFairScheduler.java:
##########
@@ -64,6 +64,7 @@ public void testGetClusterInfo() throws InterruptedException,
IOException {
FederationClusterInfo federationClusterInfo =
TestFederationSubCluster.performGetCalls(ROUTER_WEB_ADDRESS,
RM_WEB_SERVICE_PATH,
FederationClusterInfo.class, null, null);
+ Thread.sleep(2000000);
Review Comment:
Debugging?
> [GPG] Add Yarn Registry cleanup in ApplicationCleaner
> -----------------------------------------------------
>
> Key: YARN-8862
> URL: https://issues.apache.org/jira/browse/YARN-8862
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-8862-YARN-7402.v1.patch,
> YARN-8862-YARN-7402.v2.patch, YARN-8862-YARN-7402.v3.patch,
> YARN-8862-YARN-7402.v4.patch, YARN-8862-YARN-7402.v5.patch,
> YARN-8862-YARN-7402.v6.patch
>
>
> In Yarn Federation, we use Yarn Registry to use the AMToken for UAMs in
> secondary sub-clusters. Because of potential more app attempts later,
> AMRMProxy cannot kill the UAM and delete the tokens when one local attempt
> finishes. So similar to the StateStore application table, we need
> ApplicationCleaner in GPG to cleanup the finished app entries in Yarn
> Registry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]