[
https://issues.apache.org/jira/browse/YARN-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769250#comment-17769250
]
ASF GitHub Bot commented on YARN-8862:
--------------------------------------
slfan1989 commented on code in PR #6083:
URL: https://github.com/apache/hadoop/pull/6083#discussion_r1337380994
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -761,7 +761,7 @@ public AppsInfo getApps(HttpServletRequest hsr, String
stateQuery,
});
if (apps.getApps().isEmpty()) {
- return null;
+ return apps;
Review Comment:
Thank you very much for your help in reviewing the code! I was doing the
integration test of YARN Federation recently and accidentally mixed some code
into YARN-8862. I will fix this part of the code.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServicesREST.java:
##########
@@ -373,6 +373,8 @@ public void testClusterInfoXML() throws Exception {
assertEquals(
rmResponse.getRMVersion(),
routerResponse.getRMVersion());
+
+ Thread.sleep(10000000);
Review Comment:
I will fix it.
> [GPG] Add Yarn Registry cleanup in ApplicationCleaner
> -----------------------------------------------------
>
> Key: YARN-8862
> URL: https://issues.apache.org/jira/browse/YARN-8862
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-8862-YARN-7402.v1.patch,
> YARN-8862-YARN-7402.v2.patch, YARN-8862-YARN-7402.v3.patch,
> YARN-8862-YARN-7402.v4.patch, YARN-8862-YARN-7402.v5.patch,
> YARN-8862-YARN-7402.v6.patch
>
>
> In Yarn Federation, we use Yarn Registry to use the AMToken for UAMs in
> secondary sub-clusters. Because of potential more app attempts later,
> AMRMProxy cannot kill the UAM and delete the tokens when one local attempt
> finishes. So similar to the StateStore application table, we need
> ApplicationCleaner in GPG to cleanup the finished app entries in Yarn
> Registry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
