[
https://issues.apache.org/jira/browse/YARN-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859048#comment-13859048
]
Karthik Kambatla commented on YARN-1461:
----------------------------------------
Thanks Sandy. Posted a patch that incorporates most of your suggestions.
bq. Getters in GetApplicationsRequest should be Public/Stable.
All other getters and setts in GetApplicationsRequest are Public/Unstable. I
would like to leave it this way for this patch. Created YARN-1552 to graduate
all of them to Public/Stable.
{quote}
{code}
+ Set<String> appTags = parseQueries(tags, false);
+ if (!appTags.isEmpty()) {
+ checkAppTags = true;
+ }
{code}
Null check?
{quote}
parseQueries always returns a non-null set. There are couple of other uses
without a null check. I ll leave it consistent with others if that is okay.
> RM API and RM changes to handle tags for running jobs
> -----------------------------------------------------
>
> Key: YARN-1461
> URL: https://issues.apache.org/jira/browse/YARN-1461
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.2.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-1461-1.patch, yarn-1461-2.patch, yarn-1461-3.patch,
> yarn-1461-4.patch, yarn-1461-5.patch, yarn-1461-6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
