[
https://issues.apache.org/jira/browse/YARN-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864733#comment-13864733
]
Karthik Kambatla commented on YARN-1461:
----------------------------------------
Thanks for taking a look, [~zjshen].
bq. How about making the two constants configurable?
As discussed earlier on YARN-1399, I think we should leave them as constants
for now and create configs when we really think we need them.
bq. Should ApplicationSubmissionContext#newInstance have String[] tags as well?
Same for ApplicationReport and GetApplicationsRequest. Or you didn't do it on
purpose for sake of compatibility? If so, I'm just feeling we're going to have
more newInstance methods that cannot cover all the fields the objects should
have.
Intentionally left them out. IMO, there should be a single newInstance method
to create the instance and then setters be used to actually set the fields -
builder pattern.
bq. Should we consider both case-sensitive and -insensitive, and both AND and
OR logic?
It would be unnecessarily complicating things. Again, as people have suggested
on YARN-1399, case-insensitive and OR should address most cases, at least
first-cut users can handle the AND. We can support AND in the future.
> RM API and RM changes to handle tags for running jobs
> -----------------------------------------------------
>
> Key: YARN-1461
> URL: https://issues.apache.org/jira/browse/YARN-1461
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.2.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-1461-1.patch, yarn-1461-2.patch, yarn-1461-3.patch,
> yarn-1461-4.patch, yarn-1461-5.patch, yarn-1461-6.patch, yarn-1461-6.patch,
> yarn-1461-7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
