[ 
https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866397#comment-13866397
 ] 

Xuan Gong commented on YARN-1574:
---------------------------------

bq. We should be careful and make sure all AlwaysOn services that register a 
handler should be handled in setup dispatcher - may be add comments both at the 
site of calling setup dispatcher and javadoc for setup-dispatcher.

Added the comments

bq. Can we add a unit test as well? Add all handlers to the dispatcher and call 
transitions to standby and active a couple of times and make sure the number of 
handlers is right, or something along those lines?

Added a test case

> When RM transit from Active to Standby, the same eventDispatcher should not 
> be registered more than once
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1574
>                 URL: https://issues.apache.org/jira/browse/YARN-1574
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>            Priority: Blocker
>         Attachments: YARN-1574.1.patch, YARN-1574.1.patch, YARN-1574.2.patch, 
> YARN-1574.2.patch, YARN-1574.3.patch
>
>
> Currently, we move rmDispatcher out of ActiveService. But we still register 
> the Event dispatcher, such as schedulerDispatcher, RMAppEventDispatcher when 
> we initiate the ActiveService.
> Almost every time when we transit RM from Active to Standby,  we need to 
> initiate the ActiveService. That means we will register the same event 
> Dispatcher which will cause the same event will be handled several times.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to