[
https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867366#comment-13867366
]
Xuan Gong commented on YARN-1574:
---------------------------------
[~kkambatl]
bq. I also noticed CompositeService#removeService is broken. I am okay with
fixing that too in the same JIRA or a different JIRA. Either way, our tests
should probably cover that too.
Do you mean this ?
{code}
protected synchronized boolean removeService(Service service) {
synchronized (serviceList) {
return serviceList.add(service);
}
}
{code}
> When RM transit from Active to Standby, the same eventDispatcher should not
> be registered more than once
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-1574
> URL: https://issues.apache.org/jira/browse/YARN-1574
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Priority: Blocker
> Attachments: YARN-1574.1.patch, YARN-1574.1.patch, YARN-1574.2.patch,
> YARN-1574.2.patch, YARN-1574.3.patch, YARN-1574.4.patch
>
>
> Currently, we move rmDispatcher out of ActiveService. But we still register
> the Event dispatcher, such as schedulerDispatcher, RMAppEventDispatcher when
> we initiate the ActiveService.
> Almost every time when we transit RM from Active to Standby, we need to
> initiate the ActiveService. That means we will register the same event
> Dispatcher which will cause the same event will be handled several times.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
