[
https://issues.apache.org/jira/browse/YARN-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883880#comment-13883880
]
Karthik Kambatla commented on YARN-1639:
----------------------------------------
Patch looks mostly good. Nits:
# The following two lines can fit in one.
{code}
errmsg = getInvalidValueMessage(YarnConfiguration.RM_HA_ID,
id);
{code}
# The following three lines can fit in two.
{code}
String msg = "Configuration " + YarnConfiguration.RM_ADDRESS +
" must be suffixed with RM ID for HA " +
"configuration.";
{code}
# The following two lines can fit in one.
{code}
throwBadConfigurationException(
msg);
{code}
# Rename variable to currentRMId?
{code}
String currentRMID = conf.getTrimmed(YarnConfiguration.RM_HA_ID);
{code}
# rmIds is not used again, can go into the for-condition immediately following.
{code}
Collection<String> rmIds = getRMHAIds(conf);
for(String rmId : rmIds) {
{code}
# The initialization here is redundant
{code}
InetSocketAddress s = null;
{code}
> YARM RM HA requires different configs on different RM hosts
> -----------------------------------------------------------
>
> Key: YARN-1639
> URL: https://issues.apache.org/jira/browse/YARN-1639
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Arpit Gupta
> Assignee: Xuan Gong
> Attachments: YARN-1639.1.patch
>
>
> We need to set yarn.resourcemanager.ha.id to rm1 or rm2 based on which rm you
> want to first or second.
> This means we have different configs on different RM nodes. This is unlike
> HDFS HA where the same configs are pushed to both NN's and it would be better
> to have the same setup for RM as this would make installation and managing
> easier.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
