[ 
https://issues.apache.org/jira/browse/YARN-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885068#comment-13885068
 ] 

Karthik Kambatla commented on YARN-1639:
----------------------------------------

Sorry for missing this in the first go. 

By the time we return in getRMHAId(), currentRMId could be null if the config 
doesn't have any address matching localhost and ha-id is not specified. If that 
is the case, we should probably throw an exception instead of returning null. 
We should probably add another test case for this too. 

Nit: In the tests, let us use the variables RM1_NODE_ID etc. instead of the 
actual String for it.
{code}
assertEquals(conf.get(YarnConfiguration.RM_HA_ID), "rm2");
{code}




> YARM RM HA requires different configs on different RM hosts
> -----------------------------------------------------------
>
>                 Key: YARN-1639
>                 URL: https://issues.apache.org/jira/browse/YARN-1639
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Arpit Gupta
>            Assignee: Xuan Gong
>         Attachments: YARN-1639.1.patch, YARN-1639.2.patch, YARN-1639.3.patch
>
>
> We need to set yarn.resourcemanager.ha.id to rm1 or rm2 based on which rm you 
> want to first or second.
> This means we have different configs on different RM nodes. This is unlike 
> HDFS HA where the same configs are pushed to both NN's and it would be better 
> to have the same setup for RM as this would make installation and managing 
> easier.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to