[
https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888380#comment-13888380
]
Vinod Kumar Vavilapalli commented on YARN-1659:
-----------------------------------------------
Can you summarize the patch so that it's clear what the patch is focused on?
Some more comments
- Please make sure you add audience and stability annotations to all the new
classes.
- Most of these classes are internal and so don't need to be
@InterfaceAudience.Public?
The new objects
- Can we use user-facing EntityInfo, Event etc instead of creating a new
object? Or is this for decoupling user-APIs from our internal APIs.
- Is it needed as part of this patch? We can remove it and include it in the
follow-up patches where it is really needed.
GenericObjectMapper
- Writing long for a int?
- Is it needed as part of this patch? We can remove it and include it in the
follow-up patches where it is really needed.
ApplicationTimelineReader
- DEFAULT_LIMIT isn't used in the patch. For future? Document its use or
remove.
- Can we rename Field.RELATEDENTITIES etc to be hyphenated. Like
RELATED_ENTITIES?
- fields parameter -> fieldsToRetrieve
> Define ApplicationTimelineStore interface and store-facing entity,
> entity-info and event objects
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-1659
> URL: https://issues.apache.org/jira/browse/YARN-1659
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch,
> YARN-1659-5.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface. The web services
> will convert the store-facing obects to the user-facing objects.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
