[ 
https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888733#comment-13888733
 ] 

Vinod Kumar Vavilapalli commented on YARN-1659:
-----------------------------------------------

Looks better. Few more questions: 
 - you still have a 
o.a.h.y.server.applicationhistoryservice.apptimeline.Entity. Seems like it 
isn't needed anymore if you change the Reader's getEntity() API to take in both 
the ID and Type?

bq.  I don't think we should make this change, as the enum values currently 
match the names of the optional member variables of the ATSEntity object.
Note sure I follow.

Zhijie, you want to look at the patch too?

> Define ApplicationTimelineStore interface and store-facing entity, 
> entity-info and event objects
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1659
>                 URL: https://issues.apache.org/jira/browse/YARN-1659
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch, 
> YARN-1659-5.patch, YARN-1659-6.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface.  The web services 
> will convert the store-facing obects to the user-facing objects.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to