[
https://issues.apache.org/jira/browse/YARN-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892722#comment-13892722
]
Zhijie Shen commented on YARN-1635:
-----------------------------------
[~billie.rinaldi], thanks for the patch. I have a quick look at it. Here're my
comments. I still need more time to took into leveldb details.
1. Should we include ATSImport into the code base? As users are not supposed to
send the entity directly to the store, aren't the?
2. It's better to use IOUtils.cleanup to close all the Closable objects.
3. ApplicationTimelineStore APIs should allow IOException.
4. Trim the string first
{code}
+ s = s.toUpperCase();
{code}
5. Should we define some meaningful error code?
> Implement a Leveldb based ApplicationTimelineStore
> --------------------------------------------------
>
> Key: YARN-1635
> URL: https://issues.apache.org/jira/browse/YARN-1635
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Billie Rinaldi
> Attachments: YARN-1635.1.patch, YARN-1635.2.patch, YARN-1635.3.patch,
> YARN-1635.4.patch, YARN-1635.5.patch, YARN-1635.6.patch, YARN-1635.7.patch
>
>
> As per the design doc, we need a levelDB + local-filesystem based
> implementation to start with and for small deployments.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
