[
https://issues.apache.org/jira/browse/YARN-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895348#comment-13895348
]
Vinod Kumar Vavilapalli commented on YARN-1635:
-----------------------------------------------
Looked at the patch. It's quite a bit of a complex and amazing piece of code
that you wrote!
Smart key-design! Hopefully, the key design here can simply be adapted to HBase
too.
We don't need to stop this patch, but there is one specific code style issue
that you should fix in future patches.
{code}
if (!prefixMatches(prefix, prefixlen, key))
break;
{code}
In Hadoop, we put parentheses even for a single line conditional or any other
control logic structure so as to avoid the possibility of bugs due to wrong
placement of statements.
We can definitely refactor the LevelDBStore class a bit to have smaller methods
in a future patch. There are specifically some long methods.
Didn't squint hard enough to find any obvious bugs. Hopefully, the previous
existing tests in ApplicationTimelineStoreTestUtils are good enough.
+1
> Implement a Leveldb based ApplicationTimelineStore
> --------------------------------------------------
>
> Key: YARN-1635
> URL: https://issues.apache.org/jira/browse/YARN-1635
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Billie Rinaldi
> Attachments: YARN-1635.1.patch, YARN-1635.10.patch,
> YARN-1635.11.patch, YARN-1635.12.patch, YARN-1635.2.patch, YARN-1635.3.patch,
> YARN-1635.4.patch, YARN-1635.5.patch, YARN-1635.6.patch, YARN-1635.7.patch,
> YARN-1635.8.patch, YARN-1635.9.patch
>
>
> As per the design doc, we need a levelDB + local-filesystem based
> implementation to start with and for small deployments.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
