[
https://issues.apache.org/jira/browse/YARN-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904736#comment-13904736
]
Vinod Kumar Vavilapalli commented on YARN-1666:
-----------------------------------------------
Tx for the update Xuan. It looks mostly good, except for the following:
LocalConfigurationProvider:
- Use the bootstrapConf for looking into class-path. Creating configs is _not_
inexpensive!
AdminService
- In refreshNodes(), you need to create yarn-conf as {{new
YarnConfiguration(false)}}
- Similarly in refreshSuperUserGroupsConfiguration() and all the other refresh
methods. You said "It is fine. Because we will load related configuration later
by using addResource(Configuration) which will reload and overwrite all the
properties.". That is not true if we are not overwriting all properties. We
need to start on a clean slate.
HostsFileReader:
- Switch the includes and excludes sets only after both are successfully read?
> Make admin refreshNodes work across RM failover
> -----------------------------------------------
>
> Key: YARN-1666
> URL: https://issues.apache.org/jira/browse/YARN-1666
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1666.1.patch, YARN-1666.2.patch, YARN-1666.2.patch,
> YARN-1666.3.patch, YARN-1666.4.patch, YARN-1666.4.patch, YARN-1666.5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
